Unpin redis requirement #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are other things preventing us from using saq on a Redis cluster. Saw a lot of and but I suppose the redis dependency might still be possible to unpin |
|
can you make it > 4.5.4 or whatever version jr was fixed so keep the condition but also add this |
|
i'll fix it on my end |
|
Why not make it |
|
Ah cool, that's what you ended up doing. Sweet |
|
we’ll you can use 4.5.4 either… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #67
Note: I haven't deeply looked into the original reason for why it was pinned; just saw it had been resolved a while back.